feat(material/*) Focus indicator unit tests #18150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…the ripple target
…on particular components.
zelliott
changed the title
zelliott
changed the title
zelliott
requested review from
andrewseguin,
crisbeto and
devversion
as code owners
jelbourn
reviewed
Jan 11, 2020
| @@ -9,7 +9,6 @@ $mat-node-height: 48px; | |||
| align-items: center; | |||
| min-height: $mat-node-height; | |||
| flex: 1; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
It would be good to see if this changes any screenshots in Google by running a global presubmit with just this line changed
There was a problem hiding this comment.
Changed 2 screenshots, but one was an improvement in my opinion and the other was a very nit box-shadow diff of some kind. Nothing major.
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jan 21, 2020
* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target * _document should be an optional param to avoid breaking change. * Added unit tests for focus indicator, improved focus indicator color on particular components. * Some minor style changes. * Cleaned up focus indicator unit tests. * Some more minor unit test formatting changes, undo coloring changes for now. * Fixed formatting. * Fixed final linter error.
jelbourn
pushed a commit
that referenced
this pull request
Jan 28, 2020
* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target * _document should be an optional param to avoid breaking change. * Added unit tests for focus indicator, improved focus indicator color on particular components. * Some minor style changes. * Cleaned up focus indicator unit tests. * Some more minor unit test formatting changes, undo coloring changes for now. * Fixed formatting. * Fixed final linter error.
mmalerba
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target * _document should be an optional param to avoid breaking change. * Added unit tests for focus indicator, improved focus indicator color on particular components. * Some minor style changes. * Cleaned up focus indicator unit tests. * Some more minor unit test formatting changes, undo coloring changes for now. * Fixed formatting. * Fixed final linter error.
mmalerba
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target * _document should be an optional param to avoid breaking change. * Added unit tests for focus indicator, improved focus indicator color on particular components. * Some minor style changes. * Cleaned up focus indicator unit tests. * Some more minor unit test formatting changes, undo coloring changes for now. * Fixed formatting. * Fixed final linter error.
mmalerba
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target * _document should be an optional param to avoid breaking change. * Added unit tests for focus indicator, improved focus indicator color on particular components. * Some minor style changes. * Cleaned up focus indicator unit tests. * Some more minor unit test formatting changes, undo coloring changes for now. * Fixed formatting. * Fixed final linter error.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.mat-focus-indicatorexists on the appropriate element.overflow: hiddenfrom.mat-tree-nodeinMatTree(as it was cutting off some of the focus indicator).